Skip to content

Commit

Permalink
#279 Added SaaS secrets to ci [run-notebook-tests]
Browse files Browse the repository at this point in the history
  • Loading branch information
ahsimb committed Jun 5, 2024
1 parent 71a634f commit b0e5853
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,6 @@ def test_notebook(notebook_test_container_with_log, notebook_test_file):
)
environ = os.environ.copy()
environ["NBTEST_ACTIVE"] = "TRUE"
nbtest_environ = {key: value for key, value in environ.items() if key.startswith("NBTEST_")}
nbtest_environ = {key: value for key, value in environ.items() if (
key.startswith("NBTEST_") or key.startswith("SAAS_"))}
exec_command(command_run_test, container, print_output=True, environment=nbtest_environ, user="jupyter")
1 change: 1 addition & 0 deletions test/notebooks/nbtest_sagemaker.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ def continuous_job_polling():


@pytest.mark.parametrize('access_to_temp_secret_store', [StorageBackend.onprem, StorageBackend.saas], indirect=True)
@pytest.mark.skip(reason='debugging')
def test_sagemaker(access_to_temp_secret_store, uploading_hack):

store_path, store_password = access_to_temp_secret_store
Expand Down

0 comments on commit b0e5853

Please sign in to comment.