-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM64 support #1018
Add ARM64 support #1018
Conversation
Also downgrade protobuf to meet tensorflow's deps
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
I have read the CLA Document and I hereby sign the CLA |
Hi @NHellFire, thanks for this fantastic contribution! |
Using a v1.1.0 database with my branch produced an identical recognition result for these test images. Images used:
Results for the first test image are: v1.1.0 (x86_64 host):Similarity: 0.17 {
"result": [ {
"age": {
"probability": 0.9716785550117493,
"high": 32,
"low": 25
},
"gender": {
"probability": 1,
"value": "male"
},
"box": {
"probability": 0.99986,
"x_max": 1863,
"y_max": 1202,
"x_min": 1012,
"y_min": 218
},
"subjects": [ {
"subject": "A",
"similarity": 0.16651
} ],
"landmarks": [ [ 1324,
643 ],
[ 1591,
652 ],
[ 1478,
814 ],
[ 1328,
911 ],
[ 1575,
915 ] ]
} ]
} feature/arm64 (x86_64 host, same database):Similarity: 0.17 {
"result": [ {
"age": {
"probability": 0.9716785550117493,
"high": 32,
"low": 25
},
"gender": {
"probability": 1,
"value": "male"
},
"box": {
"probability": 0.99986,
"x_max": 1863,
"y_max": 1202,
"x_min": 1012,
"y_min": 218
},
"subjects": [ {
"subject": "A",
"similarity": 0.16651
} ],
"landmarks": [ [ 1324,
643 ],
[ 1591,
652 ],
[ 1478,
814 ],
[ 1328,
911 ],
[ 1575,
915 ] ]
} ]
} |
This upgrades libraries to versions that have arm64 wheels available, and builds the remaining ones (imagecodecs) from source. I've only build-tested this as I currently don't have a spare arm64 device to test on, but the test suite passed:
If anyone wants to test this, you can build the images natively with
make
from the embedding-calculator folder. Or cross-build and export the image using:And import with:
Fixes #610, possibly also #519 (I haven't tested building the CUDA images yet).
Marking as draft for now, as I still need to update the Makefile to use buildkit and try building the CUDA images. I'll also look at building imagecodecs in a separate container to reduce the final image size.