Update to newest libphonenumber #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PhoneNumberMetadata.xml` is sourced from original Google source with release 8.11.4 google/libphonenumber@876268e
PhoneNumberMetadata.xml is sourced from the original Google repo, release 8.12.9, google/libphonenumber@3ec5f5a
PhoneNumberMetadata.xml is sourced from the original Google repo, release 8.12.18, google/libphonenumber@4c532d9
Orb deployments
Bump version
Merge 0.2.3
Make package public
* Update the validation rules to 8.12.28 * Change gb invalid number
szymon-jez
changed the title
Checking if a number is possible didn't take the number type into account anyway, since in `test_number_length/2` we were always passing `PhonenUmberTypes.unknown()`. This change prevents the code from pretending like it does support validating by types. If we want to re-introduce it, we should to so properly.
This reverts commit 0c66c45.
This reverts commit ca814c0.
This reverts commit 2c5c8c2.
|
@szymon-jez Re: our Slack conversation and for documentation's sake - I tried making the updates compatible with Elixir 1.4 but I don't think it's worth it. Elixir 1.4 was released 6 years ago - packages like |
szymon-jez
commented
Apr 17, 2023
There was a problem hiding this comment.
LGTM
Great work @kamilkowalski and co. (@surgeventures)!
(Reviewed code and tested in a production app's test suite)
This was referenced Apr 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #43
The code in this branch up to commit 43111ff comes from a clone of this repository.
This is an aim to port that code over to this repo and release it in the widely used hex package.
TODOs