Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable max attempts for client errors #1094

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

studzien
Copy link
Contributor

We want to be able to apply different retry strategies depending on the error type we get back from AWS.
More specifically:

  1. We don't want to retry throughput exceeded errors to fail fast in case we temporarily overloaded AWS and bubble up the backpressure to the caller.
  2. If AWS has some internal problems and returns 500 errors for a few seconds, we want to retry them.

This PR proposes a naive approach to enabling different max_attempts to be applied to the client errors (400..499).

A more sophisticated approach is to override the whole retry strategy (including backoff values) for specific errors or error ranges.

@bernardd bernardd merged commit 50af1b8 into ex-aws:main Oct 31, 2024
12 checks passed
@bernardd
Copy link
Contributor

Looks good, thanks @studzien!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants