Fix Req example HttpClient implementation for Req 0.4+ #1026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on work in #1015 adding a bit of code to adjust the header format to the expected list of 2-element tuples.
Context
Req 0.4+ changed the headers format to be a map where the key is a string and the value is a list of strings, e.g.:
This req change makes the current example fail whenever you try to perform a streaming operation because the code in
ExAws.S3.Download
assumes a single value:With the proposed change, the example implementation should handle both new and old Req versions; though I've only tested with a recent one.