Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#30 - Fix: Prevent allowing one to select "relative to course module completion" if there is no course module with completion enabled #31

Closed

Conversation

danowar2k
Copy link
Contributor

@danowar2k danowar2k commented Mar 13, 2024

Fixes #30

…module completion" if there is no course module with completion enabled
@ewallah
Copy link
Owner

ewallah commented Mar 17, 2024

I fixed the code during a boring meeting after I only have seen your submitted issue. I did not have a clue you prepared a pull request.

I find my code is slightly better:

  • no code coverage loss
  • added Behat test to check if the changes actually work
  • reduced npath complexity yours vs mine
  • no excessively long variable names warning

So sorry I have to close the issue without merging>

@ewallah ewallah closed this Mar 17, 2024
@danowar2k
Copy link
Contributor Author

No worries, I suspected something like this :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4.2.2] "Relative to course module completion" can be added even if there are no completable modules
2 participants