#26 integers disabled samecm nocm

[danowar2k]

This PR fixes all of the problems identified in #26:

• the current course module is not offered for selection for the relative course module
• options where the module completion is disabled have the disabled attribute placement fixed
• always have an explicit course module initially selected as default to prevent "none" selection
• store JSON values as integers, not strings
• do not store the course module id if the relative date mode is not "relative to module completion"

[danowar2k]

Fixed the Moodle nagging (I stand by my opinion that having everything lower case makes reading vars worse).

Also (probably, still running) fixed the behat test. I used the wrong member of the value variable (got confused because of one letter variables).

Maybe add readable constants to the YUI module?

const RELATIVE_START = 's';

etc.

[danowar2k]

I'm stumped with the new error. I currently haven't fully setup my local behat, and the actions output doesn't show the full page HTML. When I do the stuff locally in my dev environment, the behat steps would succeed. This seems very strange.

--- Failed steps:

001 Scenario: Add relative condition ui with a module               # /home/runner/work/moodle-availability_relativedate/moodle-availability_relativedate/moodle/availability/condition/relativedate/tests/behat/availability_relativedate_ui.feature:63
      Then I should see "1 day after completion of activity Page A" # /home/runner/work/moodle-availability_relativedate/moodle-availability_relativedate/moodle/availability/condition/relativedate/tests/behat/availability_relativedate_ui.feature:73
        "1 day after completion of activity Page A" text was not found in the page

EDIT: Explanation for the missing Selenium: My current dev environment is, sadly, Solaris. I'm transitioning to RHEL, so I avoid getting anything to work on Solaris if I don't really have to. Economics of time and sanity.

[danowar2k]

Better wait for my Github action to complete: https://github.com/danowar2k/moodle-availability_relativedate/actions/runs/8038749498

[danowar2k]

Finally. It lives!!!!