Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows build config #1

Merged
merged 1 commit into from
Jun 13, 2024
Merged

windows build config #1

merged 1 commit into from
Jun 13, 2024

Conversation

jgarnierGit
Copy link
Contributor

Hi!

First I'd like to say that I'm really glad to find out your repo and to see you are actively working on it :D
That's so cool !

I bring you this contribution to build your repo on windows CMD environment
I removed the part related to the user rights as Windows has its own personal way to deal with that,

Also I was not confident with your workflow of launching build.sh, then run the serve-dir alias ?
I found out it may be redundant, at least I get the expected result by running the command I've documented in the README,md
Feel free to tell me more about it !

Cheers,
Jonathan

@evoyy evoyy merged commit 1262718 into evoyy:master Jun 13, 2024
@evoyy
Copy link
Owner

evoyy commented Jun 13, 2024

Thanks. I still haven't managed to get it fully working. See this comment for details: projectM-visualizer/projectm#812 (comment)

I have a few things to try:

@evoyy
Copy link
Owner

evoyy commented Jun 13, 2024

Also, I clarified the serve-dir alias in the readme. It was a bit confusing. It's only needed if you don't have python installed locally (like me).

@jgarnierGit
Copy link
Contributor Author

I will stay up-to-date on your work, you saved me a lot of time and pain!

FYI, I used it on a personal project https://github.com/jgarnierGit/web-music-library ;)

@evoyy
Copy link
Owner

evoyy commented Jun 14, 2024

Glad to hear it helped. It was admittedly a pain to get projectM working. At least it's kind of working now. The only things to fix now are to work out why there is a 5-7 seconds delay when loading presets, and the transitions/blend feature cause it to freeze when changing presets, so that feature is disabled. Hopefully the projectM maintainers can help look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants