Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-11585: Update local testdata for roles to match production data #8540

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

minnakt
Copy link
Contributor

@minnakt minnakt commented Dec 9, 2024

DEVPROD-11585

Description

This PR just updates local data to match what's in production.

I actually already did the work to fix the tests in a previous PR (/pull/8456), but I set project_patches to the wrong value. This PR sets project_patches to the correct value of 0.

@minnakt minnakt marked this pull request as ready for review December 9, 2024 17:52
@minnakt minnakt requested review from a team and removed request for a team December 9, 2024 17:53
{"_id":"basic_project_access","name": "basic access","scope":"unrestricted_projects","permissions":{"project_tasks":20,"project_patches":10,"project_logs":10,"project_task_annotations":10}}
{"_id":"admin_project_access","name":"admin project access","scope":"all_projects","permissions":{"project_logs":10,"project_patches":0,"project_tasks":10,"project_settings":10,"project_task_annotations":20}}
{"_id":"basic_distro_access","name":"basic distro access","scope":"all_distros","permissions":{"distro_settings":10,"distro_hosts":10}}
{"_id":"basic_project_access","name": "basic project access","scope":"unrestricted_projects","permissions":{"project_tasks":20,"project_patches":10,"project_logs":10,"project_task_annotations":10}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basic project access patches should be reduced to 0 (instead of 10), and task annotations can be upped to 20

[
  {
    _id: 'basic_project_access',
    name: 'basic access',
    scope: 'unrestricted_projects',
    permissions: {
      project_tasks: 20,
      project_patches: 0,
      project_logs: 10,
      project_task_annotations: 20
    }
  }
]

Copy link
Contributor

@ablack12 ablack12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tasks pass with that update though

@minnakt minnakt changed the title DEVPROD-11585: Update admin_project_access role for local data DEVPROD-11585: Update local testdata in roles.json to match production data Dec 11, 2024
@minnakt minnakt changed the title DEVPROD-11585: Update local testdata in roles.json to match production data DEVPROD-11585: Update local testdata for roles to match production data Dec 11, 2024
@minnakt minnakt merged commit b50bffe into evergreen-ci:main Dec 11, 2024
10 checks passed
@minnakt minnakt deleted the DEVPROD-11585 branch December 11, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants