DEVPROD-13240 staging environment header for the CLI #8534
Merged
+28
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadjri
reviewed
Dec 10, 2024
operations/http.go
Outdated
| APIKey string | ||
| APIRootV2 string | ||
| UIRoot string | ||
| environment string |
There was a problem hiding this comment.
Is there a plan to use this for non-staging environments? If not we can rename to something like stagingEnvironment for clarity.
There was a problem hiding this comment.
changed to stagingEnvironment
hadjri
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-13240
Description
The rc legacyClient strips the path out of the URL (to remove
/api) so the path based routing for staging environments doesn't work. Instead, the CLI will be able to connect to the correct staging instance by specifying the X-Evergreen-Environment header.Testing
Used the CLI to create a patch, which was previously failing because it uses
rchere.