DEVPROD-12452 account for when the host was last provisioned when checking system failures #8491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking system failures
hadjri
approved these changes
Nov 25, 2024
model/event/host_event_finder.go
Outdated
| or := ResourceTypeKeyIs(ResourceTypeHost) | ||
| or[TypeKey] = EventHostTaskFinished | ||
| or[ResourceIdKey] = hostId | ||
| func getRecentStatusesForHost(ctx context.Context, hostId string, hostProvisionTime time.Time, n int) (int, []string) { |
There was a problem hiding this comment.
nit: can we rename this to getRecentTaskFinishedStatusesForHost or something similar since this function ignores other host event logs
model/event/host_event_finder.go
Outdated
| @@ -64,12 +66,13 @@ func getRecentStatusesForHost(ctx context.Context, hostId string, n int) (int, [ | |||
| } | |||
|
|
|||
| // AllRecentHostEventsAreSystemFailed returns true if all recent host events are system failures, and false if any are not. | |||
| func AllRecentHostEventsAreSystemFailed(ctx context.Context, hostId string, n int) bool { | |||
| // Only takes into account events that occurred since the last time the task started running. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-12452
Description
Only quarantine a host if it's had three consecutive failures since it was last provisioned. Using provision time for this. Verified with https://evergreen.mongodb.com/rest/v2/hosts/ec2-3-89-114-149.compute-1.amazonaws.com that the field is what I'd expect.
Testing
Added unit testing
Documentation
remember to add or edit docs in the docs/ directory if relevant