DEVPROD-7550: fix calculating next stop time when editing schedule #7918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadjri
reviewed
May 28, 2024
model/host/host.go
Outdated
| // calculating both the next start and next stop times. If the next start | ||
| // time is set first on the schedule, the next stop time can be pushed | ||
| // further into the future than necessary. | ||
| // kim: TODO: add test for next stop set based on now rather than next |
There was a problem hiding this comment.
Should this be ticketed or removed?
There was a problem hiding this comment.
Oops this was already added to the tests. I removed the comment.
hadjri
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-7550
Description
Fix a bug where the sleep schedule's next stop time might be bumped too far in the future because the next start time is set on the schedule first. Both next start and next stop should be based on the current moment. For example, if it's 3pm right now and the user sets the host to a 9am - 5pm schedule, the next stop should logically be at 5pm today. However, the prior logic would set the next stop to 5pm tomorrow because it looked for a next stop time after the next start time (which is at 9am tomorrow).
Testing
Added unit test.
Documentation
N/A