DEVPROD-7219 Remove db access from cli commands #7912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablack12
requested changes
May 22, 2024
| return errors.Errorf("project ref '%s' not found", projectIdentifier) | ||
| } | ||
| // Projects that use the GitHub merge queue cannot enqueue to the commit queue. | ||
| apiPatch.CanEnqueueToCommitQueue = (p.HasValidGitInfo() || p.IsGithubPRPatch()) && proj.CommitQueue.MergeQueue != model.MergeQueueGitHub |
There was a problem hiding this comment.
This field is only used by the UI, right? Instead of including this here, could we instead remove CanEnqueueToCommitQueue from the APIPatch struct and instead just add a resolver for it? (like
evergreen/graphql/patch_resolver.go
Line 62 in e002320
There was a problem hiding this comment.
(@khelif96 is that reasonable?)
There was a problem hiding this comment.
Yeah this makes sense to me
ablack12
reviewed
May 24, 2024
khelif96
approved these changes
May 27, 2024
ablack12
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-7219
Description
Adding a db call to get project during API creation broke this function for the CLI
We now ignore the db calls when it comes from the CLI
When the function is called from the CLI, it returns the same value it used to return before the calls to the db were added
Testing
works locally