Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVPROD-5460: Apply requireProjectAccess directive to repoId instead of id #7702

Merged
merged 5 commits into from
Apr 3, 2024
Merged

DEVPROD-5460: Apply requireProjectAccess directive to repoId instead of id #7702

merged 5 commits into from
Apr 3, 2024

Conversation

minnakt
Copy link
Contributor

@minnakt minnakt commented Apr 2, 2024 •
edited
Loading

DEVPROD-5460

Description

Right now, the project access directive applies to id, but we want it to apply to the new repoId argument instead.

Next steps

  • UI PR to remove the leftover id argument on repo queries.
  • Evergreen PR to remove all of the outdated arguments.

Testing

  • Updated GraphQL tests
  • Locally against GraphQL server with different users

@minnakt minnakt marked this pull request as ready for review April 2, 2024 21:52
@minnakt minnakt requested a review from a team April 2, 2024 21:52
sophstad
sophstad approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@sophstad sophstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great diva

@minnakt
Copy link
Contributor Author

minnakt commented Apr 3, 2024

(Will wait to merge until Spruce gets deployed since it depends on Spruce 😇)

@minnakt minnakt changed the title DEVPROD-5460: Apply project access directive to new repoId argument DEVPROD-5460: Apply @requireProjectAccess directive to repoId instead of id Apr 3, 2024
@minnakt minnakt changed the title DEVPROD-5460: Apply @requireProjectAccess directive to repoId instead of id DEVPROD-5460: Apply requireProjectAccess directive to repoId instead of id Apr 3, 2024
@minnakt minnakt merged commit ecbd1e5 into evergreen-ci:main Apr 3, 2024
8 checks passed
@minnakt minnakt deleted the DEVPROD-5460_2 branch April 3, 2024 19:02
@minnakt minnakt mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophstad sophstad sophstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minnakt @sophstad