-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVPROD-4573: Query hosts by Running status for Task Queue UI #7690
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
850110f
Omit 'building' from active host status list
SupaJoon 35fda58
Revert "Omit 'building' from active host status list"
SupaJoon 87bc6f7
ByRunninStatus query
SupaJoon 19bfc2d
Merge branch 'main' of https://github.com/evergreen-ci/evergreen into…
SupaJoon a1476e2
CountRunningStatusHosts
SupaJoon 22b9eab
specify distro in query
SupaJoon 706ee45
update test
SupaJoon ce63cca
CR
SupaJoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ | |
{ | ||
"id": "debian71-test", | ||
"taskCount": 0, | ||
"hostCount": 1 | ||
"hostCount": 0 | ||
} | ||
] | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -232,6 +232,16 @@ func runningHostsQuery(distroID string) bson.M { | |
return query | ||
} | ||
|
||
// byRunningStatusQuery produces a query that returns all hosts | ||
// with the running status that belong to the given. | ||
func byRunningStatusQuery(distroID string) bson.M { | ||
distroIDKey := bsonutil.GetDottedKeyName(DistroKey, distro.IdKey) | ||
return bson.M{ | ||
distroIDKey: distroID, | ||
StatusKey: evergreen.HostRunning, | ||
} | ||
} | ||
|
||
func idleStartedTaskHostsQuery(distroID string) bson.M { | ||
query := bson.M{ | ||
StatusKey: bson.M{"$in": evergreen.StartedHostStatus}, | ||
|
@@ -263,6 +273,11 @@ func CountRunningHosts(ctx context.Context, distroID string) (int, error) { | |
return num, errors.Wrap(err, "counting running hosts") | ||
} | ||
|
||
func CountRunningStatusHosts(ctx context.Context, distroID string) (int, error) { | ||
num, err := Count(ctx, byRunningStatusQuery(distroID)) | ||
return num, errors.Wrap(err, "counting Running status hosts") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: shouldn't capitalize running |
||
} | ||
|
||
func CountAllRunningDynamicHosts(ctx context.Context) (int, error) { | ||
query := IsLive() | ||
query[ProviderKey] = bson.M{"$in": evergreen.ProviderSpawnable} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: missing "distro" and the end there i think