DEVPROD-4117: Treat missing include files as FileNotFoundError #7458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-4117
Description
Noticed this in the sandbox project in staging, where no mainline commit versions had been triggered in quite some time despite all repotracker configurations being correct. It turns out that one of the older commits in sandbox introduced an
includelist, even though those included files were nonexistent.This created a bug in the repotracker job where this conditional doesn't evaluate for missing include files, causing the store revisions loop to error and exit rather than continue. This is because when include files are not found, Evergreen doesn't treat it as a
FileNotFoundErrorhence we miss these checks.This is a rather concerning bug, as it could lead to a stuck waterfall / fire requiring manual DB update in production if some project were to do the same.
This change makes it such that when an include file is not found, treat the error as a
FileNotFoundError.Testing
Confirmed that deploying this change to staging unblocked the stuck sandbox project.