Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed double letter insert and paste issue for android #1844

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fixed double letter insert and paste issue for android #1844

merged 2 commits into from
Nov 21, 2023

Conversation

desperado1802
Copy link
Contributor

@desperado1802 desperado1802 commented Nov 20, 2023 •
edited
Loading

@desperado1802 desperado1802 added bug Something isn't working MOBILE Mobile app issues logic labels Nov 20, 2023
@desperado1802 desperado1802 added this to the v0.1.0 milestone Nov 20, 2023
@desperado1802 desperado1802 self-assigned this Nov 20, 2023
@desperado1802 desperado1802 linked an issue Nov 20, 2023 that may be closed by this pull request
[BUG] Code Input not working properly in production for android devices #1827
Closed
@evereq
Copy link
Member

evereq commented Nov 20, 2023

Hm, can't we find maybe some component for such things??? It looks VERY weird that we have to write such "low-level" functionality ourselves! Maybe there is prebuilt component for accepting such "code" inputs for ReactNative etc. Can you search!?

@desperado1802
Copy link
Contributor Author

Hm, can't we find maybe some component for such things??? It looks VERY weird that we have to write such "low-level" functionality ourselves! Maybe there is prebuilt component for accepting such "code" inputs for ReactNative etc. Can you search!?

I found this one @evereq https://www.npmjs.com/package/react-native-confirmation-code-field. Should we use it?

@evereq
Copy link
Member

evereq commented Nov 21, 2023

Yes please @desperado1802

@socket-security Socket Security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
react-native-confirmation-code-field 7.3.2 None +0 20.8 kB retyui

@evereq
Copy link
Member

evereq commented Nov 21, 2023

@desperado1802 please let me know when we can merge it

@desperado1802
Copy link
Contributor Author

@desperado1802 please let me know when we can merge it

Testted on iOS, and Android in emulator. Working fine. We can merge @evereq

@evereq evereq merged commit 257afb4 into develop Nov 21, 2023
10 of 11 checks passed
@evereq evereq deleted the bug/code-input-fix-android branch November 21, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evereq evereq Awaiting requested review from evereq

@badalkhatri0924 badalkhatri0924 Awaiting requested review from badalkhatri0924

Assignees

@desperado1802 desperado1802

Labels
bug Something isn't working logic MOBILE Mobile app issues
Projects
Ever Teams Platform
Status: ✅ Done
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

[BUG] Code Input not working properly in production for android devices
2 participants
@desperado1802 @evereq