fix: coderabbitai

ever-co · Nov 26, 2024 · 3269eaa · 3269eaa
1 parent dcee5bd
commit 3269eaa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/apps/web/app/[locale]/timesheet/[memberId]/components/TimesheetView.tsx b/apps/web/app/[locale]/timesheet/[memberId]/components/TimesheetView.tsx
@@ -5,7 +5,7 @@ import { useTranslations } from 'next-intl';
 export function TimesheetView({ data, loading }: { data?: GroupedTimesheet[]; loading?: boolean }) {
 	const t = useTranslations();
 
-	if (!data) {
+	if (loading || !data) {
 		return (
 			<div className="grow h-full w-full bg-[#FFFFFF] dark:bg-dark--theme flex items-center justify-center">
 				<p>{t('pages.timesheet.LOADING')}</p>

diff --git a/apps/web/lib/features/integrations/calendar/table-time-sheet.tsx b/apps/web/lib/features/integrations/calendar/table-time-sheet.tsx
@@ -579,10 +579,11 @@ const HeaderColumn = ({
 	onSort: () => void;
 	currentSort: SortOrder | null;
 }) => (
-	<div className="flex gap-x-2">
+	<div className="flex gap-x-2" role="columnheader">
 		<span>{label}</span>
 		<button
 			onClick={onSort}
+			aria-label={`Sort ${label} column ${currentSort ? `currently ${currentSort.toLowerCase()}` : ''}`}
 			className="flex flex-col items-start leading-none gap-0"
 		>
 			<MdKeyboardArrowUp
@@ -633,7 +634,11 @@ const HeaderRow = ({
 			style={{ backgroundColor: bgOpacity, borderBottomColor: bg }}
 			className="flex items-center text-[#71717A] font-medium border-b border-t dark:border-gray-600 space-x-4 p-1 h-[60px] w-full"
 		>
-			<Checkbox onCheckedChange={() => handleSelectRowByStatusAndDate(status, date!)} className="w-5 h-5" />
+			<Checkbox
+				onCheckedChange={() => date && handleSelectRowByStatusAndDate(status, date)}
+				className="w-5 h-5"
+				disabled={!date}
+			/>
 			<div className="flex-[2]">
 				<HeaderColumn
 					label="Task"