A first draft of a document describing Matrix state and state resolution (second attempt) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non-Jedi
reviewed
Nov 30, 2017
| ** A total order over states (as by "Erik's draft" and current Synapse) | ||
| For two events =A= and =B=, | ||
| =A < B= if =A='s depth is less than =B='s, | ||
| or, if their depths are equal, |
There was a problem hiding this comment.
This could be more clear. Do you mean something like:
if depth(A) < depth(B):
A < B
elseif depth(A) == depth(B) & hash(A) < hash(B):
A < B
else:
A > B
The phrasing of the sentence for the second condition is just a bit awkward and
convoluted.
| if the hash value of =A= is less than | ||
| the hash value of =B=. | ||
| Otherwise, =B > A=. | ||
|
|
There was a problem hiding this comment.
A practical example would be very helpful here. Especially interested in an
example with branches that have more than one event in them. To me what you
describe here sounds like those events would be interleaved, but that doesn't
seem to match what I've seen synapse do in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same content as was approved by @maxidor in #5, but that was merged before @non-Jedi had reviewed, leading to #7. So here's the second attempt.