Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: embed tz data for planner #17881

Closed
wants to merge 2 commits into from
Closed

Conversation

naltatis
Copy link
Member

fixes #17850

This package will be automatically imported if you build with -tags timetzdata.
https://pkg.go.dev/time/tzdata

@andig Die Doku sagt, dass das alternativ auch über Build Parameter geht. Wäre das eine alternative? Müsste dann in den Release-Prozess eingebaut werden. Hat den Vorteil, dass wir das "Windows only" machen könnten und das App-Bundle nicht für alle größer wird.

@naltatis naltatis added the bug Something isn't working label Dec 24, 2024
@naltatis naltatis requested a review from andig December 24, 2024 08:27
@andig
Copy link
Member

andig commented Dec 24, 2024

Hat den Vorteil, dass wir das "Windows only" machen könnten und das App-Bundle nicht für alle größer wird.

Super Idee. Das muss dann in die goreleaser.yml mit rein- da wo heute auch das Mac Build angepasst wird.

@andig andig closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiederholender Ladeplan: request failed with status code 400
2 participants