-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elering: add all Nordpool regions #17493
Conversation
additional regions for norway (1-5) and sweden (1-4) line 14, validvalues
@andig yes, we should introduce a field with structured country data to improve the documentation. Currently we (mis)use the descriptions field for this. When we have it structured we could introduce proper sections on the documentation page and later build multilevel selection for tariffs in config ui: "select you country > select a tariff for your country". @lka-hh can you update the description accordingly? |
fixed spacing and casing
@lka-hh out of curiosity: shouldn't the same be possible for Energinet? They have dk1,2 however and those are not present here? |
ping @lka-hh |
Hej,
Ich wårde das Template Nordpool taufen, die Beschreibung ändern/ergänzen und alle auf der Nordpool-homepage vorhandenen Regionen eintragen. Ich bin neu hier und haben keine Erfahrungen in der Handhabung von github und dessen Funktionen. Bin neugierig und will gerne was neues lernen. Brauche aber vermutlich eine Weile wenn ich es mir selbst beibringe. Vielleicht könnt ihr mir tips geben und habt einen Vorschlag wo ich mehr dazu lesen kann, wie man hier am besten arbeitet |
changed template name to Nordpool, regions for Austria, Belgium, Denmark, France, Poland, Romania added in line 14
@@ -1,19 +1,19 @@ | |||
template: elering | |||
template: Nordpool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break existing installs. Either: keep old name. Or:
template: nordpool
covers: ["elering"]
I'd indeed leave the name since that's the actual API we're using.
- preset: tariff-base | ||
render: | | ||
type: elering | ||
type: Nordpool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type: Nordpool | |
type: elering |
there is no "Nordpool" Go code ;)
This PR looks strange to me, as Elering only provides data for the 4 countries (FI, EE, LV, LT) |
Do we still need Elering at all after #17628? |
additional regions for norway (1-5) and sweden (1-4) in line 14, validvalues