Fix: render testing skips tests after first usage == 0 #13805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrimmiMeloni
added
bug
|
Bei mir läuft alles durch, nur sehr langsam: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug originally introduced as part of #10272.
The return I am getting rid off here now would have had to become a continue when I changed the logic back last year.
That said, removing it simply also is OK, is the range over usages will not even start the loop if the usage count is 0.
Additionally, and why I am marking as draft @andig, is that now that more tests are running again, some of the recent changes now started to show failures when running locally.
I assume some errors are OK, while others might actually indicate we have a real issue with some of the default data + template combinations. I am frankly unsure how to confirm if these errors are real or not, so I could use some help with sorting these.