fix: use standardized units in text outputs #3784
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The small
b
was misleading as it usually means "bit", whereas here we have "bytes". Also, the prefixesk
,m
andg
did not match any existing convention, here as we are dividing by 1024, we should useKi
,Mi
andGi
to prevent any confusion.See: https://en.wikipedia.org/wiki/Byte#Multiple-byte_units
EDIT: sorry, after more testing I noticed it now looks misaligned.EDIT2: fixed.