Support unlimited length for null *print-length* #368
Conversation
|
Nice!
Can you create test code for this?
2019年3月28日(木) 19:00 Affonso, Guilherme <[email protected]>:
Solves #365 <#365> and is
cl-compatible.
According to CLHS
*print-length* controls how many elements at a given level are printed.
If it is false, there is no limit to the number of components printed.
This PR commits do:
1. Support unlimited printing when *print-length* is nil
2. Fix *print-length* bug in vector printing, that was preventing for
limit to be reached
1.eus$ (setq *print-length* 2)
2
2.eus$ (vector 1 2 3)
#(1 2 3)
1. Do not put spaces after the ...; do not print first element of
lists when *print-level* is set to 0.
Was also going to update for unlimited *print-level* as well, but the
printer starts to segfault before the max value 65536 is reached, so am
leaving that untouched for now.
------------------------------
You can view, comment on, or merge this pull request online at:
#368
Commit Summary
- Support unlimited *print-length*
- Fix *print-length* on print-vector
- Unify *print-length* formatting
File Changes
- *M* lisp/c/printer.c
<https://github.com/euslisp/EusLisp/pull/368/files#diff-0> (54)
Patch Links:
- https://github.com/euslisp/EusLisp/pull/368.patch
- https://github.com/euslisp/EusLisp/pull/368.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#368>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3OFNGMyQRuWir9R0NwVCuTgMF_A2ks5vbJK6gaJpZM4cPvGd>
.
--
--
◉ Kei Okada
|
Affonso-Gui
force-pushed
the
print-length
branch
from
11dcdf4
to
ec1d9a2
Compare
|
@k-okada Added ansi-test based test code |
Affonso-Gui
changed the title
…rguments in funcdesc/methoddoc
…ot supported on rtd docker file
use readthedoc theme for RTD.org
Affonso-Gui
force-pushed
the
print-length
branch
from
ec1d9a2
to
6e106ee
Compare
add config.yml for CircelCI
make osx build stable
…ix wrong arguments in funcdesc/methoddoc same fix as 5f96c10
fix tex files in jlatex to make latex.py happy, {\bfx } -> \bfx{ }, fix wrong arguments in funcdesc/methoddoc
stop executing all the next steps if there is no doc update, see https://discuss.circleci.com/t/ability-to-return-successfully-from-a-job-before-completing-all-the-next-steps/12969/7
Fix variable capture in unittest.l
Fix export typo interger-vector > integer-vector
apt-get update before apt-get install
Affonso-Gui
force-pushed
the
print-length
branch
from
6e106ee
to
c37aa8c
Compare
|
Updated branch |
|
Thank you for contributing EusLisp documentation PDF version of English manual: manual.pdf |
Safely exit format on mismatch argument
install pkg-config. skip collision test for old bullet.
travis.sh: install libbullet-dev for jskeus tests
Affonso-Gui
force-pushed
the
print-length
branch
from
c37aa8c
to
86a65f1
Compare
Affonso-Gui
force-pushed
the
print-length
branch
from
86a65f1
to
da9804f
Compare
|
Thank you for contributing EusLisp documentation PDF version of English manual: manual.pdf |
|
can we port this feature to |
|
is this |
Should I make the needed changes and re-target this PR to master branch?
It is cl-compatible, but I am not sure how it should be classified. Depending on how one arguments it can be said that it changes/extends existing features, add new features or fix bugs. |
Solves #365 and is cl-compatible.
According to CLHS
This PR commits do:
...; do not print first element of lists when print-level is set to 0.Was also going to update for unlimited
*print-level*as well, but the printer starts to segfault before the max value 65536 is reached, so am leaving that untouched for now.