Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a dockerfile that builds on arm #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chadbrewbaker
Copy link

I created a docker file that builds on arm.

@aurelf
Copy link
Member

aurelf commented Jun 11, 2021

Hi @chadbrewbaker, thanks for your PR! Really appreciated!

I have a few questions:

  • could you also add something about it on the documentation or ReadMe ? With an example platform where you tested it ?
  • changes vs the original Dockerfile seem to be only LLVM related compilation flags, is this because of a problem with LLVM version on ARM ? It would be good to document it too, so we know the reason (which may change over time)
  • Can we modify the original docker file instead, like with a flag or arch specific support (https://docs.docker.com/desktop/multi-arch/ or rather something like https://stackoverflow.com/a/58222507 ) I'm afraid that the two Dockerfiles would diverge over time and this would lead to problems...
  • Were you able to use SymCC successfully on ARM ?

@chadbrewbaker
Copy link
Author

I wrote/executed it on my aarch64 mac M1 with the latest docker and symcc. It built the sample C++ program and emitted about 8 traces, one of which found the flag - "root" was it?

Sure, I can look at detecting the architecture and merging the two Docker files. llvm-10 toolchain worked fine.

@sebastianpoeplau
Copy link
Collaborator

It would be great to make sure that Mac users can build the Docker image, but I agree with @aurelf that we should try to make our existing Dockerfile compatible with AArch64 Macs instead of adding another one. Sadly, I don't have a device to test on, and GitHub doesn't seem to provide hosted AArch64 CI runners yet.

Let's see if we can find any volunteers to test on a Mac. Otherwise, I'm going to close the PR in a couple weeks or so.

@sebastianpoeplau sebastianpoeplau added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants