-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection interface #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've left a few remarks. Let's define some tests for the new connection class.
src/Messages/IPointToInterlockingConnection/IPointToInterlockingConnection.cs
Outdated
Show resolved
Hide resolved
src/Messages/IPointToInterlockingConnection/IPointToInterlockingConnection.cs
Outdated
Show resolved
Hide resolved
Tried to fix the test issue without sucess. https://learn.microsoft.com/en-us/archive/blogs/msbuild/node-reuse-in-multiproc-msbuild https://github.com/eulynx-live/subsystems/actions/runs/7043163481/job/19168476653?pr=15 https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-build#msbuild |
There was an infinite loop in Test_Default_Position. Also recommended reading: https://learn.microsoft.com/en-us/dotnet/standard/parallel-programming/task-cancellation |
This change decouples the
Point
class from specific communication protocols and enables it to communicate with various endpoints through a standardized interface. ThePoint
class now interacts with an object of typeIPointToInterlockingConnection
, which defines the necessary communication methods. This approach make the system more flexible, allowing the Point class to seamlessly integrate with different communication mechanisms in the future such as mocked connections for testing.