Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection interface #15

Merged
merged 22 commits into from
Dec 3, 2023
Merged

Connection interface #15

merged 22 commits into from
Dec 3, 2023

Conversation

Scretch9
Copy link
Collaborator

This change decouples the Point class from specific communication protocols and enables it to communicate with various endpoints through a standardized interface. The Point class now interacts with an object of type IPointToInterlockingConnection, which defines the necessary communication methods. This approach make the system more flexible, allowing the Point class to seamlessly integrate with different communication mechanisms in the future such as mocked connections for testing.

@Scretch9 Scretch9 self-assigned this Nov 24, 2023
@Scretch9 Scretch9 requested a review from rs22 November 24, 2023 15:46
Copy link
Contributor

@rs22 rs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've left a few remarks. Let's define some tests for the new connection class.

src/FieldElementSubsystems.Test/Point/PointTest.cs Outdated Show resolved Hide resolved
src/Point/PointToInterlockingConnectionB4R1Impl.cs Outdated Show resolved Hide resolved
src/Point/PointToInterlockingConnectionB4R1Impl.cs Outdated Show resolved Hide resolved
src/Point/PointToInterlockingConnectionB4R1Impl.cs Outdated Show resolved Hide resolved
src/Point/PointToInterlockingConnectionB4R1Impl.cs Outdated Show resolved Hide resolved
src/Point/PointToInterlockingConnectionB4R1Impl.cs Outdated Show resolved Hide resolved
@rs22
Copy link
Contributor

rs22 commented Dec 3, 2023

There was an infinite loop in Test_Default_Position.

Also recommended reading: https://learn.microsoft.com/en-us/dotnet/standard/parallel-programming/task-cancellation

@rs22 rs22 merged commit 125361e into main Dec 3, 2023
1 check passed
@rs22 rs22 deleted the ConnectionInterface branch December 3, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants