Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logic to continue keys loading even if key is not in the list… #323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oleksandrsarapulovgl
Copy link
Contributor

… as it could be deleted from the BE

@dslmeinte
Copy link

Can someone review this PR? @kristank (from eu-digital-green-certificates/dgca-verifier-service#82) e.g.?

@kristank
Copy link

Hello,

@dslmeinte

At this time I do not have access to the whole stack (build environment for android app, ability to prepare test cases on dgca-verifier-service, ...) so I cannot reliably verify the change, but after examining the change in android code I think this would work.

I would still recommend to evaluate if this is the proper way to fix this issue. I think this should be fixed in dgca-verifier-service (I reported the error in that service, link to the issue eu-digital-green-certificates/dgca-verifier-service#82), because the root of the problem (at least the way I see it, I can be wrong) is two methods of the service returns inconsistent data (details in the linked issue), instead of fixing the android, ios and every other clients that are using the dgca-verifier-service data. And deploying the fix to the service is much "easier" than each user upgrading the mobile app.

I hope this helps. If I can be of any other assistance, please let me know.

@dslmeinte
Copy link

@SchulzeStTSI @MykhailoNester Can you have a look at this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants