Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italian translations #24

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

M3kH
Copy link
Contributor

@M3kH M3kH commented May 1, 2021

Add Italia translations, not perfect but a good enough start.
Please CC if you know someone who can review.

"CZ": "Numero del documento d'intentitá",
"HC": "Codice Fiscale",
"NI": "Numero Nazionale d'intedificazione dell'individuo",
"MB": "Numero membro",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this one

"PPN": "Numero di passaporto",
"NN": "Numero del documento d'identitá",
"CZ": "Numero del documento d'intentitá",
"HC": "Codice Fiscale",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is equivalent, but would be nice if someone from the Health Ministry of Italy would give a double check

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M3kH, I guess you are a native speaker, only do not know about the right/official wording. Nevertheless thanks for your contribution. We will clarify this.

src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
@M3kH M3kH requested a review from a team as a code owner October 30, 2021 11:38
@M3kH
Copy link
Contributor Author

M3kH commented Oct 30, 2021

Thanks @Robotex for the review, good suggestions.

"serverError": "É accaduto un errore:",
"error-patient-data-load": "Non siamo riusciti a caricare i dati del paziente.",
"statistics": "Statistiche",
"failed-report": "Impossibile caricare la pratica per il test",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "a failure in producing a report of tests" or a "report of tests which had a failure"?
I tend to believe the second one given the English original.

Suggested change
"failed-report": "Impossibile caricare la pratica per il test",
"failed-report": "Report dei test falliti",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this PR has being open for too long and the current reference files have diverge.
I believe this was meant to show an error message when the test couldn't be loaded.

@M3kH
Copy link
Contributor Author

M3kH commented Oct 31, 2021

@not-a-kiwi thanks for your review.

@ascheibal Some more people have add additional efforts in redact this contributions, is a pity if there would no be follow up.

Copy link

@pierpaolobaghe pierpaolobaghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I would like to propose some changes to the source, in order to make this more precise for italian native speakers.
These ones are a bit more correct.

I am at your disposal for any questions you might have.

src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
src/assets/i18n/it/translation.json Outdated Show resolved Hide resolved
Co-authored-by: Pierpaolo Baghe <[email protected]>
Co-authored-by: not-a-kiwi <[email protected]>
@M3kH
Copy link
Contributor Author

M3kH commented Nov 7, 2021

Thanks @pierpaolobaghe for your review and contribution, the problem is that this PR seems not to grasp any interest in being merge in the codebase in the first place.

@pierpaolobaghe
Copy link

pierpaolobaghe commented Nov 7, 2021

Thanks @pierpaolobaghe for your review and contribution, the problem is that this PR seems not to grasp any interest in being merge in the codebase in the first place.

Hi @M3kH ,
I saw this PR is not being given much attention.
My hope is that by having a sufficient amount of contributions, attention would be brought back to this.

Being italian, I know for sure lots of people struggle with english. IMHO making technology accessible (and usable) should be a priority (at least for official things such as this repo).

Thanks for your feedback
I'll still keep contributing whenever possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants