Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another Pydantic 2 support #832

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Conversation

ZipFile
Copy link
Contributor

@ZipFile ZipFile commented Nov 30, 2024

This PR supersede #803, #786, #785 (partially), #768 and fixes #755, #726.

Notable differences:

  • Updated GHA pipeline to run tests against two versions of Pydantic.
  • Better error messages depending on installed Pydantic version.
  • Minor code de-duplication.

There is one necessary but unrelated commit to fix compatibility with httpx v0.27.0. Without this change tests are failing.

@coveralls
Copy link

Coverage Status

coverage: 94.261% (+0.02%) from 94.246%
when pulling 8cec99d on ZipFile:pydantic2
into cab75cb on ets-labs:develop.

Copy link
Member

@rmk135 rmk135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@rmk135 rmk135 merged commit c61fc16 into ets-labs:develop Dec 7, 2024
14 checks passed
@ZipFile ZipFile deleted the pydantic2 branch December 7, 2024 16:42
@ZipFile ZipFile added enhancement github_actions Pull requests that update GitHub Actions code labels Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants