Adding hashes to system tab URLs #5535
Open
+121
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5535/merge
|
| Run status |
|
| Run duration | 00m 57s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
galvana
commented
Nov 25, 2024
| @@ -31,6 +35,38 @@ import { | |||
| import SystemInformationForm from "~/features/system/SystemInformationForm"; | |||
| import { SystemResponse } from "~/types/api"; | |||
|
|
|||
| const SYSTEM_TABS = { | |||
There was a problem hiding this comment.
Formalizing this a bit so we don't have so many magic numbers and strings floating around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LA-167
Description Of Changes
Adds URL "fragments" for the different tabs in the system page. This allows us to deep-link into specific tabs. It also allows us to navigate back to a specific system tab if needed.
Code Changes
useSystemFormTabs.tsxSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works