Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx: move all transaction methods into their respective capabilities #3796

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Tx: move all transaction methods into their respective capabilities #3796

wants to merge 5 commits into from

Conversation

jochem-brouwer
Copy link
Member

This PR is part of #3733

It is inspired by: https://notes.ethereum.org/@holgerd77/HkMPmMc-Je

This PR:

  • Removes all the transaction methods from their transaction classes and move these into the Capabilities

It also renames features/util.ts to capabilities/generic.ts, since the old "util feature" is essentially a generic capability.

WIP.

@jochem-brouwer jochem-brouwer mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: tx PR state: WIP type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jochem-brouwer