Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

discovery v5 support #48

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

discovery v5 support #48

wants to merge 18 commits into from

Conversation

timxor
Copy link

@timxor timxor commented Dec 31, 2018

Replaces original PR #42

Fixes issue #19

Nearly ready for approval.

Cleaning up right now and addressing @holgerd77 comments .

Task name Status? Required Description
new PR ✅ Yes Yes collaborator administrative control granted
clean up ✅ Yes Yes remove debug print lines
finalize example 🚧 Wip Optional remove debug print lines

Feel free to run with it! Happy NYE, hope to work on this more come February 🤗

@timxor
Copy link
Author

timxor commented Dec 31, 2018

@holgerd77 looks like I need to address the Travis CI build still. Will try to do this evening.

@holgerd77
Copy link
Member

Thanks for submitting, very close to the finish line, a handful of more linting error to be fixed. Shouldn't be too complicated, you can eventually just temporarily add a --fix flag to the linting command. 😄

@holgerd77 holgerd77 removed their assignment Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants