This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
discovery v5 support #48
Open
timxor
wants to merge
18
commits into
master
Choose a base branch
from
discovery-v5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timxor
added
PR state: needs review
bounty: submitted
bounty: done
and removed
PR state: WIP
labels
Dec 31, 2018
Closed
@holgerd77 looks like I need to address the Travis CI build still. Will try to do this evening. |
Thanks for submitting, very close to the finish line, a handful of more linting error to be fixed. Shouldn't be too complicated, you can eventually just temporarily add a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces original PR #42
Fixes issue #19
Nearly ready for approval.
Cleaning up right now and addressing @holgerd77 comments .
Feel free to run with it! Happy NYE, hope to work on this more come February 🤗