Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit congestion control timeout amplification #70

Merged
merged 5 commits into from
Jun 6, 2023

Conversation

jacobkaufmann
Copy link
Collaborator

we have observed that the congestion control timeout can amplify quickly to the point where the timeout becomes not so useful. for example, the timeout should not exceed the maximum idle timeout.

summary:

  • add a maximum timeout field to congestion control
  • limit the number of timeouts registered with congestion control by the connection
  • add a maximum timeout field to the connection config
    • by default, this value is equal to the max idle timeout

@jacobkaufmann jacobkaufmann requested a review from carver June 5, 2023 17:57
@jacobkaufmann
Copy link
Collaborator Author

@carver this should address some of the issues raised in #69

@jacobkaufmann jacobkaufmann merged commit 9e6e6d2 into master Jun 6, 2023
@carver carver deleted the timeout-fixes branch June 6, 2023 18:37
@carver carver mentioned this pull request Jun 7, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant