Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant call in same thread #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove redundant call in same thread #64

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9881c67
Remove redundant call in same thread
May 28, 2023
637e8cc
fixup! Remove redundant call in same thread
May 28, 2023
6a163d7
Remove code from experimental branch
May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/conn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,18 +454,23 @@ impl<const N: usize, P: ConnectionPeer> Connection<N, P> {
window -= n;
}

let mut wrote_data = false;
// Write as much data as possible into send buffer.
while let Some((data, ..)) = self.pending_writes.front() {
if data.len() <= send_buf.available() {
let (data, tx) = self.pending_writes.pop_front().unwrap();
send_buf.write(&data).unwrap();
let _ = tx.send(Ok(data.len()));
self.writable.notify_one();
wrote_data = true;
} else {
break;
}
}

if wrote_data {
self.writable.notify_one();
}

// Transmit data packets.
// TODO: Helper for construction of DATA packet.
let mut seq_num = sent_packets.next_seq_num();
Expand Down Expand Up @@ -525,8 +530,6 @@ impl<const N: usize, P: ConnectionPeer> Connection<N, P> {
}

self.process_writes(Instant::now());

self.writable.notify_waiters();
}

fn process_reads(&mut self) {
Expand Down