Prevent client from deadlocking/halting on large transfer by throwing error #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 26, 2023
KolbyML
changed the title
KolbyML
force-pushed
the
return-error-add-todo
branch
from
0959ed0 to
4b549f4
Compare
KolbyML
changed the title
|
Closing since I think we should merge #65 as the temporary solution to solve this problem. It adds complexity, but we will have to chunk data either way. Hopefully soon we can refactor the two pending write buffers into 1 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue can be read in this PR #56
This is a quick solution to the problem, with a further improvement added as a TODO
ping for request to review @jacobkaufmann