fix: properly encode/decode started_at_ms
in QueryTrace object
#1591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
fixes the second part of ethereum/portal-network-specs#352
We were exposing the implementation details of
SystemTime
for thestarted_at_ms
when encoding theQueryTrace
object. This doesn't comply with our Json-RPC spec.As
started_at_ms
is supposed to be encoded as a milisecond timestamp.Json only allows for u64's which will last us for millions of years.
for example this is what we are currently returning before this fix
but the result is supposed to be like
How was it fixed?
started_at_ms
to a u64