feat: only bridge newly created contracts #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morph-dev
approved these changes
Oct 28, 2024
trin-execution/src/storage/evm_db.rs
Outdated
| @@ -102,6 +106,15 @@ impl EvmDB { | |||
| trie_diff | |||
| } | |||
|
|
|||
| pub fn get_newly_created_contract_if_available(&self, code_hash: B256) -> Option<Bytecode> { | |||
There was a problem hiding this comment.
nit: I think that get_newly_created_contract is clear enough in this case. Up to you.
KolbyML
force-pushed
the
only-gossip-newly-created-contracts
branch
from
26bb524 to
2f56ff4
Compare
morph-dev
reviewed
Oct 28, 2024
portal-spec-tests
Outdated
There was a problem hiding this comment.
I don't think this should be here. I assume you rebased to master, but didn't handle submodules correctly.
I don't know why all tests are still passing, so I could be wrong.
Just wanted to highlight it, so you can double check what is happening.
There was a problem hiding this comment.
I didn't rebase that is an artifact from me switching from master
KolbyML
force-pushed
the
only-gossip-newly-created-contracts
branch
from
2f56ff4 to
042c3be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We would always bridge contracts, which isn't good because the contract should already be gossiped on the network. This takes up a lot of bridge bandwidth, which is redundant as the contracts should already be on the network.
How was it fixed?
By using a
cacheto store newly created contracts like we do forstorage_triediffs.