Continue searching for content when an earlier transfer of content fails, or is invalidated #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2024
If a find content query is transferring content from a peer, and it fails, then resume pinging peers to get the content from another one. Ways we have seen the content transfer fail: - peer disappears during utp transfer - peer sends invalid content - peer implements utp differently For now, partially to simplify testing and architecture, we only validate one piece of content at a time. When a piece of content is returned, we prioritize starting validation. When validation has started, we pause all other activity: finding new peers, finding the content elsewhere, and validating more copies of already-found content. Those things resume only after the active validation fails. It could be nice to run validation on 2 or more copies of content at a time, but testing this would be much more complicated (at least with the current testing approach).
mrferris
approved these changes
Sep 24, 2024
| @@ -56,15 +56,15 @@ pub enum FindContentQueryPending<TNodeId> { | |||
| // peer that sent the content | |||
| peer: TNodeId, | |||
| // channel used to send back the validated content info | |||
| valid_content_tx: Sender<ValidatedContent<TNodeId>>, | |||
| valid_content_tx: Sender<Option<ValidatedContent<TNodeId>>>, | |||
There was a problem hiding this comment.
We spoke about how to differentiate between a failed utp and failed validation within the trace, and you mentioned it would be tough to send the trace between threads. I think we could instead pass back a wrapper datatype enum here with ValidatedContent, FailedUtp, and FailedValidation variants instead of None on failure.
Not a blocker on this PR.
There was a problem hiding this comment.
Yup, I see where you're going.
As a preview of where my mind is at: since the query trace is not accessible from inside the query, I think the distinction between the types of failure might not matter to the query itself. The trace will have to know the distinction, but that will be out in the overlay service somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #1383
How was it fixed?
To-Do