Add ContentNotFoundError
#343
Conversation
| }, | ||
| "errors":[{ | ||
| "$ref": "#/components/errors/ContentNotFoundErrorWithTrace" | ||
| }] | ||
| }, |
There was a problem hiding this comment.
Seems like we're also going to want to add this error to simple RecursiveFindContent requests? I'm split on whether we want to include the trace w/ the error for these endpoints... probably not i guess... and just use the simple ContentNotFoundError type
jsonrpc/src/errors/errors.json
Outdated
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "ContentNotFoundError": { | |||
| "code": -32099, | |||
There was a problem hiding this comment.
We are using 39001 for this in the code (see PR https://github.com/ethereum/portal-network-specs/pull/276/files)
There was a problem hiding this comment.
I'm still seeing the wrong error code here? Maybe the change didn't get merged? And if we're going with 39001 for ContentNotFoundError then we should go with something like 39002 for ContentNotFoundErrorWithTrace?
There was a problem hiding this comment.
Ugh, sorry, the commit didn't grab the changes in this file. Should be correct now.
jsonrpc/src/errors/errors.json
Outdated
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "ContentNotFoundError": { | |||
| "code": -32099, | |||
There was a problem hiding this comment.
I'm still seeing the wrong error code here? Maybe the change didn't get merged? And if we're going with 39001 for ContentNotFoundError then we should go with something like 39002 for ContentNotFoundErrorWithTrace?
In the process of researching Ultralight test failures for Hive, I discovered that the JSON RPC spec currently advises that the
portal_*localContentmethods return0xwhen no content is found.However, this did not solve a hive test failure for
portal_beaconLocalContentfor Ultralight when I updated our code to match this spec. After further research, I discovered thattrinandfluffyreturn an error and not0xwhen content is not found. This PR updates the spec to reflect the current implemented state of the clients.Specifically:
portal_*localContentresponses to reflect that the clients return an errorContentNotFoundErrora specifies that the error code returned should be -32001 for theContentNotFoundErrorand the message "content not found" following the current Trin implementation.ContentNotFoundErrorWithTraceerror type that is returned by thetraceRecursiveFindContentmethod types