Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove epoch accumulator history network content type #268

Closed

Conversation

njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Jan 24, 2024

There has been some discussion in Discord regarding whether or not it's worth storing epoch accumulators in the network. I've listed some of the main points below, but please add any other relevant points.

Pro (aka. let's remove the accumulators)

  • Nobody on the network is currently using this data
    • Bridges keep a local store of the accumulators (to build proofs)
  • It uses up wasted network storage/bandwidth
  • Requires extra work - eg. tooling support (glados / portal-hive / etc..)

Con (aka. let's keep them in the network)

  • It may be useful to support block_hash by block_number lookups (for pre-merge blocks)

@njgheorghita
Copy link
Contributor Author

Personally, I'm in favor of removing them for the time being. We don't have a current use case. It will not be difficult to re-introduce the content type once the use-case is fully justified.

@KolbyML
Copy link
Member

KolbyML commented Jan 24, 2024

Removing EpochAccumulayors takes time away from debugging real issues making our network unstable.

Our bandwidth bottleneck has to do with us sending 2 udp packets for every 1 uTP packet. uTP packets are sent over TalkRequests which requires a talk response. This is our biggest networking bottleneck and also a very low priority.

Removing it takes dev time what can resolve issues stopping us from launching a 4444's network.

I am not sure how this PR relates to the MVP Milestones. This seems like a side quest we should talk about in 6-12 months

@KolbyML
Copy link
Member

KolbyML commented Jan 24, 2024

Currently nobody uses the network. So of course nobody uses it yet. Have gotten confirmation from fluffy that they already use it.

With how I wrote NClientTestSpec and test creation automation on Portal Hive it would take 5-15 minutes to add tests for EpochAccumators the hardest part is me getting the content key/value myself which would be using logs to dump it from the bridge

@njgheorghita
Copy link
Contributor Author

Have gotten confirmation from fluffy that they already use it.

Yup, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants