Clarify finality update FINDCONTENT handling #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
reviewed
Oct 23, 2023
| For `FindContent` requests: | ||
| - a requesting node will either know the last previous finalized slot, if it has been following the updates, or it will | ||
| have to guess slots that are potentially finalized. | ||
| - a responding node SHOULD reply with its current finality update if it corresponds the same or a newer slot than the one |
There was a problem hiding this comment.
Suggested change
| - a responding node SHOULD reply with its current finality update if it corresponds the same or a newer slot than the one | |
| - a responding node SHOULD reply with its current finality update if it corresponds to the same or a newer slot than the one |
There was a problem hiding this comment.
Or, I think we should actually make this MUST?
Suggested change
| - a responding node SHOULD reply with its current finality update if it corresponds the same or a newer slot than the one | |
| - a responding node MUST reply with its current finality update if it corresponds to the same or a newer slot than the one |
ogenev
approved these changes
Oct 24, 2023
|
Is this still relevant? Should it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimistic Update Keyfromoptimistic_slottosignature_slotleft over from Update beacon network test vectors to latest spec #235FOUNDCONTENTresponses forLightClientFinalityUpdateshould contain a node's latest Finality Update (if its local finality update is the same or later than the one requested in aFINDCONTENTmessage.