Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ethereum_clis): move TransitionTool.verify_fixture() to StateTest and BlockTest #935

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Nov 4, 2024

🗒️ Description

This PR refactors ethereum_clis and the consume direct interface so that it can be extended to other clients.

Previously, the GethTransitionTool class implemented fixture consumption and referred to it as "fixture verification". The reason is historical: the first "consumer" was implemented in fill.

This PR:

  • Adds GethStatetest and GethBlocktest interface consumer classes to the evm statetest, respectively evm_blocktest commands.
  • Adds a GethFixtureConsumer class which applies the appropriate consumer class for the fixture to run against the client.

Note, that as we now instantiate the GethStatetest and GethBlocktest classes from within GethFixtureConsumer we don't currently use any of the binary detection/automatic subclass instantiation provided by EthereumCLI that is used for the TransitionTool.

🔗 Related Issues

None.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.

@danceratopz danceratopz added type:refactor Type: Refactor scope:consume Scope: Consume command suite labels Nov 4, 2024
@danceratopz danceratopz self-assigned this Nov 18, 2024
binary: Path
cached_version: Optional[str] = None

def __init__(self, binary: Path, trace: bool = False, exception_mapper=GethExceptionMapper()):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we can actually override exception mapper for consume wrappers right?

shutil.copyfile(fixture_path, debug_fixture_path)


class GethTransitionTool(GethEvm, TransitionTool):
Copy link
Collaborator

@winsvega winsvega Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel It is not necessarily GethEvm, it just happened to be inside gethEvm
for evmone it will be a standalone (nested from ethereum cli) class? it is a bit confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:consume Scope: Consume command suite type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants