Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): EOF - EIP-7692: migrate CALLF execution tests #914

Merged
merged 1 commit into from
Oct 31, 2024
Merged

new(tests): EOF - EIP-7692: migrate CALLF execution tests #914

merged 1 commit into from
Oct 31, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 24, 2024 •
edited
Loading

🗒️ Description

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened: Remove migrated EOF execution tests tests#1410.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@pdobacz pdobacz mentioned this pull request Oct 24, 2024
Merged
@chfast chfast force-pushed the eof/migrate_callf_exec branch from c26bee0 to ce1c178 Compare October 25, 2024 09:16
@chfast chfast added scope:tests Scope: Test cases type:test Type: Test labels Oct 25, 2024
@chfast chfast mentioned this pull request Oct 25, 2024
Merged
8 tasks
@chfast chfast force-pushed the eof/migrate_callf_exec branch from ce1c178 to dead793 Compare October 26, 2024 07:30
@chfast chfast marked this pull request as ready for review October 26, 2024 07:30
pdobacz
pdobacz approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@chfast chfast force-pushed the eof/migrate_callf_exec branch from dead793 to 02181af Compare October 28, 2024 14:53
shemnon
shemnon reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add container_post to each test to verify the slot_code_worked was set.

@chfast chfast force-pushed the eof/migrate_callf_exec branch from 02181af to 8298c2f Compare October 29, 2024 08:43
@chfast
Copy link
Member Author

chfast commented Oct 29, 2024

No idea what the CI failure is.

@pdobacz
Copy link
Collaborator

pdobacz commented Oct 29, 2024

No idea what the CI failure is.

#920 fixes this

@chfast chfast force-pushed the eof/migrate_callf_exec branch from 8298c2f to b9b8309 Compare October 30, 2024 10:36
@chfast
Copy link
Member Author

chfast commented Oct 30, 2024

Rebased. Can we merge this?

@marioevz marioevz changed the title new(tests): migrate CALLF execution tests new(tests): EOF - EIP-7692: migrate CALLF execution tests Oct 31, 2024
@marioevz marioevz merged commit e6d3cdc into ethereum:main Oct 31, 2024
3 checks passed
@marioevz marioevz deleted the eof/migrate_callf_exec branch October 31, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon left review comments

@pdobacz pdobacz pdobacz approved these changes

@marioevz marioevz Awaiting requested review from marioevz

Assignees
No one assigned
Labels
scope:tests Scope: Test cases type:test Type: Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chfast @pdobacz @shemnon @marioevz