-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coverage): Enable coverage on any test change (rebased with uv) #790
Conversation
5899822
to
90659f2
Compare
38fbbd5
to
eaee649
Compare
eaee649
to
b4edd64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment, I think it should simplify the logic and make it a bit less fragile.
a4c2735
to
b4edd64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged with #839 |
95cd543
to
1767e96
Compare
need to exclude prague folder from coverage. but also need to check how change files behave if changes are done to prague and outside of prague. |
d922729
to
3105192
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried out the flow locally and it's working well with the negative path matches in the Changed Files plugin 👍
A few minor comments below:
- Is there any reason why you're not filling with xdist enabled? The flow took 21m 32s locally and the main
fill
call was 13 mins of this. - We should also ignore Osaka for now?
do not skip the coverage script for safety
e148996
to
461facc
Compare
-n auto might be breaking >> log capture. |
e4aaedd
to
84a1388
Compare
fix uv run fill on empty file set
84a1388
to
b20eb69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for implementing this!
I had to create a dummy PR to verify this because act
is acting funny when running this workflow for some reason. I think we can merge as is because at the end of the day we need the workflow to work on the CI and not necessarily locally, but we can eventually revisit and see if we can fix it somehow.
Yes. Changed files gives me crypto not found error. The author says he doesn't use this in any way. Dan doesn't have this issue. |
🗒️ Description
Enable coverage script on any test .py files changes:
if no new lines in converted-ethereum-tests.txt, then seek for .py files with tests and compare the coverage
from before and after PR, otherwise it compares the coverage from test repo and .py produced tests as before.
Script is reworked. use uv to run fill correctly
remove retesteth to simplify the script
use changed files github macro to detect changed files
🔗 Related Issues
Demo: #841
Rebase of: #707
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.