Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eof tracker coverage [TEST] #774

Closed
wants to merge 9 commits into from
Closed

Conversation

winsvega
Copy link
Collaborator

@winsvega winsvega commented Aug 29, 2024

๐Ÿ—’๏ธ Description

Test run coverage script on PR773

๐Ÿ”— Related Issues

#773

โœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega
Copy link
Collaborator Author

So here the run:

Original BASE tests:
legacy_initcode_invalid_eof_v1_contract_6bb88772b0d02288a917611b82d42e3f778bd2ee.json
legacy_initcode_valid_eof_v1_contract_6bb88772b0d02288a917611b82d42e3f778bd2ee.json
magic_validation_6bb88772b0d02288a917611b82d42e3f778bd2ee.json
max_code_sections_6bb88772b0d02288a917611b82d42e3f778bd2ee.json
single_code_section_6bb88772b0d02288a917611b82d42e3f778bd2ee.json
version_validation_6bb88772b0d02288a917611b82d42e3f778bd2ee.json
--------------------
Ported PATCH tests:
coverage.json
invalid_containers.json
magic_validation.json
max_code_sections.json
single_code_section.json
valid_containers.json
version_validation.json

no lines lost. more lines gained.
New covered Lines: 93
New covered function Paths: 184

But keep in mind that new lines covered is a little dirty with coverage.json

@marioevz
Copy link
Member

marioevz commented Sep 2, 2024

Thanks for this, will be closing this since the other PR has been merged.

@marioevz marioevz closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants