-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EOF - EIP-3540: out of order container section #741
Conversation
2210511
to
272db5e
Compare
551663b
to
e349ae9
Compare
Test containers section being out of order in the header and/or body. This extends and follows the convention of the test_section_order() for the optional container section. This also converts EOFTests/efValidation/EOF1_section_order_.json.
e349ae9
to
465f544
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for the coverage explanation!
Yes, I guess this will only be an issue for converted tests for which the spec has changed. Thanks for all the details on this, very helpful indeed. |
You see the coverage script is helpful even if it gets red. I also found a few issues in my tests because of the cocerage report. |
Yes, it is very helpful. I had to go back and add some missing test context multiple times. However, sometimes it may be considered unnecessary (https://github.com/ethereum/execution-spec-tests/pull/741/files#diff-ca4727af81398c427b5141ac76705400e44ba6d1afc25500f82032e1f8904756R227). |
- EOFTests/efValidation/EOF1_embedded_container_.json ethereum/execution-spec-tests#763 - EOFTests/efValidation/EOF1_section_order_.json ethereum/execution-spec-tests#741
- EOFTests/efValidation/EOF1_embedded_container_.json ethereum/execution-spec-tests#763 - EOFTests/efValidation/EOF1_section_order_.json ethereum/execution-spec-tests#741
🗒️ Description
Test containers section being out of order in the header and/or body.
This extends and follows the convention of the test_section_order()
for the optional container section.
This also converts EOFTests/efValidation/EOF1_section_order_.json.
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.