Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): migrate "valid" EOFCREATE validation #738

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 9, 2024

πŸ—’οΈ Description

Migrate EOFCREATE tests from ethereum/tests which become outdated (contain unreferenced subcontainers).

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Add optional `Container.expected_bytecode` with raw bytes
of the expected constructed bytecode.
This allows confirming that raw EOF and `Container()` representations
are identical.
@chfast chfast requested review from marioevz and winsvega August 9, 2024 23:08
@chfast chfast force-pushed the eof/migrate_eofcreate_valid branch from 2050b72 to d6815c3 Compare August 9, 2024 23:19
@marioevz marioevz merged commit c250604 into ethereum:main Aug 10, 2024
5 of 6 checks passed
@marioevz marioevz deleted the eof/migrate_eofcreate_valid branch August 10, 2024 00:24
chfast added a commit to ethereum/tests that referenced this pull request Aug 19, 2024
- EOFTests/EIP3540/validInvalid.json: ethereum/execution-spec-tests#598
- EOFTests/efValidation/EOF1_truncated_section_.json: ethereum/execution-spec-tests#740
- EOFTests/efValidation/EOF1_eofcreate_valid_.json: ethereum/execution-spec-tests#738
winsvega pushed a commit to ethereum/tests that referenced this pull request Aug 20, 2024
- EOFTests/EIP3540/validInvalid.json: ethereum/execution-spec-tests#598
- EOFTests/efValidation/EOF1_truncated_section_.json: ethereum/execution-spec-tests#740
- EOFTests/efValidation/EOF1_eofcreate_valid_.json: ethereum/execution-spec-tests#738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants