Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): EOF - EIP-4750: Runtime stack overflow at CALLF #678

Merged
merged 3 commits into from
Jul 17, 2024
Merged

new(tests): EOF - EIP-4750: Runtime stack overflow at CALLF #678

merged 3 commits into from
Jul 17, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jul 10, 2024

🗒️ Description

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@gumb0 gumb0 force-pushed the eof-callf-stack-overflow branch 4 times, most recently from f7de47e to 8ce811b Compare July 11, 2024 14:09
marioevz
marioevz reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, let me know if #682 makes sense with this PR in mind.

tests/prague/eip7692_eof_v1/eip4750_functions/test_callf_execution.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip4750_functions/test_callf_execution.py Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip4750_functions/test_callf_execution.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip4750_functions/test_callf_execution.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip4750_functions/test_callf_execution.py Outdated Show resolved Hide resolved
@gumb0 gumb0 force-pushed the eof-callf-stack-overflow branch 3 times, most recently from cf0b923 to eb2a41e Compare July 12, 2024 15:39
@gumb0 gumb0 force-pushed the eof-callf-stack-overflow branch from eb2a41e to d87a27e Compare July 12, 2024 16:43
@gumb0 gumb0 force-pushed the eof-callf-stack-overflow branch from d87a27e to e0d1495 Compare July 16, 2024 14:16
@gumb0 gumb0 marked this pull request as ready for review July 17, 2024 13:07
@gumb0 gumb0 requested a review from marioevz July 17, 2024 13:07
@marioevz marioevz changed the title Tests for runtime stack overflow at CALLF new(tests): EOF - EIP-4750: Runtime stack overflow at CALLF Jul 17, 2024
marioevz
marioevz approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@marioevz marioevz merged commit 0154afa into ethereum:main Jul 17, 2024
4 checks passed
@marioevz marioevz deleted the eof-callf-stack-overflow branch July 17, 2024 16:37
@gumb0 gumb0 mentioned this pull request Jul 18, 2024
Merged
8 tasks
@pdobacz pdobacz mentioned this pull request Jul 22, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gumb0 @marioevz