Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): coverage script support #669

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

winsvega
Copy link
Collaborator

@winsvega winsvega commented Jul 4, 2024

🗒️ Description

Farther support of the coverage git workflow:

  • The scripts errors out properly if the test filling didn't work
  • If eof test is detected, retesteth run will be skipped as eof format has changed
  • Fix missing coverage file to run with type3 transaction (that covers 16 lines in evmone)
  • Use docker hub login to grant more download attempts of docker images

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega force-pushed the coveragescript branch 11 times, most recently from 0691417 to c80cd83 Compare July 4, 2024 11:39
@winsvega winsvega changed the title coverage script [TEST] fix(tests): coverage script support Jul 4, 2024
@winsvega winsvega requested a review from marioevz July 4, 2024 11:46
@winsvega winsvega force-pushed the coveragescript branch 4 times, most recently from 855fbb5 to 4e62a46 Compare July 4, 2024 15:14
exit code on fill errors, coverage test fix
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@winsvega winsvega merged commit 9c4ab21 into ethereum:main Jul 8, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants