Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): add tests for EOF container prefix #605

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Jun 7, 2024

πŸ—’οΈ Description

More systematic way to test cases focused on 3 first bytes of EOF container. This actually replaces many "example" invalid EOF tests.

πŸ”— Related Issues

#598

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast force-pushed the eof/container_prefix branch from c9b1e45 to f7419c1 Compare June 7, 2024 07:27
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should also take the opportunity and remove the test cases we are covering here from tests/prague/eip7692_eof_v1/eip3540_eof_v1/container.py.

@chfast chfast force-pushed the eof/container_prefix branch 3 times, most recently from cddd552 to 3dd68e5 Compare June 10, 2024 19:35
@chfast
Copy link
Member Author

chfast commented Jun 10, 2024

take the opportunity and remove the test cases we are covering here from tests/prague/eip7692_eof_v1/eip3540_eof_v1/container.py.

done.

Also remove similar "manual" tests in container.py.
@chfast chfast force-pushed the eof/container_prefix branch from 3dd68e5 to a4dd890 Compare June 11, 2024 11:15
@marioevz marioevz merged commit d769517 into ethereum:main Jun 11, 2024
5 checks passed
@chfast chfast deleted the eof/container_prefix branch June 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants